-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update publish-package.yaml #217
Conversation
WalkthroughThe main functional adjustment introduces Changes
Poem
Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/publish-package.yaml (1 hunks)
Additional comments not posted (1)
.github/workflows/publish-package.yaml (1)
131-131
: LGTM! The dependency order ensures the version is available.The addition of
print_version_to_publish
to theneeds
list ensures that the version information is available when sending the slack notification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [feat] refactor the package publication workflow (#152) * [test] create release (#153) * [feature] remove legacy workflow to create gh release (#157) * Test/create release workflow (#155) * [test] create release * [test] create release - 2 * Update publish-package.yaml (#158) * [fix] add condition check back * Fix CI syntax issue * Cenevan demo (#195) * Create test-slack-notifs.yml * Update test-slack-notifs.yml * Update test-slack-notifs.yml (#196) * Changed description and title for demo (#197) * Update test-slack-notifs.yml * Update test-slack-notifs.yml * Update publish-package.yml (#193) * Update publish-package.yaml * Update publish-package.yaml * Update publish-package.yaml * reusable slack workflow implemented * Update publish-package.yaml (#211) * Update publish-package.yaml (#217) * Bump up react sdk to 0.0.1 * Make react-sdk test's timeout longer * Update publish-package.yaml * Update @story-protocol/[email protected] in react sdk * Fix nonce issue when run integration test * Update style when run npm run generate command * Skip test about Non-Commercial Remix * Upgrade pnpm/action-setup version --------- Co-authored-by: Andy Wu <[email protected]> Co-authored-by: Ze <[email protected]> Co-authored-by: cenevan <[email protected]>
Description
Fix slack notification version not being displayed properly
Test Plan
See if slack notification works on next release
Notes
Summary by CodeRabbit
print_version_to_publish
job runs before sending Slack notifications, improving the sequence of task execution.