Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publish-package.yaml #217

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Update publish-package.yaml #217

merged 1 commit into from
Jul 3, 2024

Conversation

cenevan
Copy link
Contributor

@cenevan cenevan commented Jul 2, 2024

Description

Fix slack notification version not being displayed properly

Test Plan

See if slack notification works on next release

Notes

  • Example: Links and navigation need to be added to the front-end interface

Summary by CodeRabbit

  • Chores
    • Updated the workflow to ensure the print_version_to_publish job runs before sending Slack notifications, improving the sequence of task execution.

Copy link

coderabbitai bot commented Jul 2, 2024

Walkthrough

The main functional adjustment introduces print_version_to_publish as a prerequisite for the send_slack_notif job in the GitHub Actions workflow. This ensures the version information is printed before the Slack notification is sent.

Changes

File Summary
.github/workflows/publish-package.yaml Add print_version_to_publish dependency for send_slack_notif job

Poem

🐇 In scripts so clean, where code does hum,
A new task joins the workflow drum.
Print the version, then notify,
On Slack, we send our cheerful cry.
Each step in line, not skipped, not sly,
A coder’s dream, beneath the byte-sky. 🚀

Tip

AI model upgrade

gpt-4o model for reviews and chat is now live

OpenAI claims that this model is better at understanding and generating code than the previous models. Please join our Discord Community to provide any feedback or to report any issues.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0393af4 and 38d3418.

Files selected for processing (1)
  • .github/workflows/publish-package.yaml (1 hunks)
Additional comments not posted (1)
.github/workflows/publish-package.yaml (1)

131-131: LGTM! The dependency order ensures the version is available.

The addition of print_version_to_publish to the needs list ensures that the version information is available when sending the slack notification.

Copy link
Contributor

@AndyBoWu AndyBoWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndyBoWu AndyBoWu merged commit d1b4685 into main Jul 3, 2024
8 of 9 checks passed
@AndyBoWu AndyBoWu deleted the evan/fix-slack-notifs branch July 3, 2024 18:36
edisonz0718 added a commit that referenced this pull request Jul 9, 2024
* [feat] refactor the package publication workflow (#152)

* [test] create release (#153)

* [feature] remove legacy workflow to create gh release (#157)

* Test/create release workflow (#155)

* [test] create release

* [test] create release - 2

* Update publish-package.yaml (#158)

* [fix] add condition check back

* Fix CI syntax issue

* Cenevan demo (#195)

* Create test-slack-notifs.yml

* Update test-slack-notifs.yml

* Update test-slack-notifs.yml (#196)

* Changed description and title for demo (#197)

* Update test-slack-notifs.yml

* Update test-slack-notifs.yml

* Update publish-package.yml (#193)

* Update publish-package.yaml

* Update publish-package.yaml

* Update publish-package.yaml

* reusable slack workflow implemented

* Update publish-package.yaml (#211)

* Update publish-package.yaml (#217)

* Bump up react sdk to 0.0.1

* Make react-sdk test's timeout longer

* Update publish-package.yaml

* Update @story-protocol/[email protected] in react sdk

* Fix nonce issue when run integration test

* Update style when run npm run generate command

* Skip test about Non-Commercial Remix

* Upgrade pnpm/action-setup version

---------

Co-authored-by: Andy Wu <[email protected]>
Co-authored-by: Ze <[email protected]>
Co-authored-by: cenevan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants