Refactor metadata param in spg #178

bonnie57 · 2024-05-13T10:22:52Z

Description

Refactor metadata
Cancel block time when forking rpc
Fix PIL_TYPE import error
Fix Optimization commercialShare number
Fix Add Function to add Metadata to IP Asset
Complete dispute integration tests
Clean env variables and set env example file
Integrate signature into ipAsset

Test Plan

bonnie57 requested review from DonFungible, edisonz0718, jacob-tucker and AndyBoWu as code owners May 13, 2024 10:22

bonnie57 had a problem deploying to external May 13, 2024 10:22 — with GitHub Actions Failure

bonnie57 temporarily deployed to external May 13, 2024 10:27 — with GitHub Actions Inactive

bonnie57 changed the title ~~Dev~~ Refactor metadata param in spg May 13, 2024

bonnie57 had a problem deploying to beta-sepolia May 14, 2024 01:45 — with GitHub Actions Failure

bonnie57 temporarily deployed to external May 14, 2024 04:22 — with GitHub Actions Inactive

bonnie57 had a problem deploying to beta-sepolia May 14, 2024 04:22 — with GitHub Actions Failure

bonnie57 force-pushed the dev branch from 16a6fcf to 8d54ec4 Compare May 14, 2024 05:39

bonnie57 had a problem deploying to external May 14, 2024 05:39 — with GitHub Actions Failure

bonnie57 temporarily deployed to external May 14, 2024 05:39 — with GitHub Actions Inactive

bonnie57 had a problem deploying to beta-sepolia May 14, 2024 05:44 — with GitHub Actions Failure

bonnie57 temporarily deployed to external May 14, 2024 09:17 — with GitHub Actions Inactive

bonnie57 had a problem deploying to external May 14, 2024 09:17 — with GitHub Actions Failure

bonnie57 had a problem deploying to beta-sepolia May 14, 2024 18:42 — with GitHub Actions Failure

bonnie57 had a problem deploying to beta-sepolia May 14, 2024 19:03 — with GitHub Actions Failure

bonnie57 temporarily deployed to external May 15, 2024 05:39 — with GitHub Actions Inactive

bonnie57 had a problem deploying to beta-sepolia May 15, 2024 19:08 — with GitHub Actions Failure

bonnie57 had a problem deploying to beta-sepolia May 15, 2024 19:09 — with GitHub Actions Failure

bonnie57 temporarily deployed to external May 16, 2024 03:38 — with GitHub Actions Inactive

bonnie57 had a problem deploying to beta-sepolia May 16, 2024 03:38 — with GitHub Actions Failure

bonnie57 temporarily deployed to external May 16, 2024 03:45 — with GitHub Actions Inactive

bonnie57 had a problem deploying to beta-sepolia May 16, 2024 03:45 — with GitHub Actions Failure

bonnie57 temporarily deployed to external May 16, 2024 04:23 — with GitHub Actions Inactive

bonnie57 had a problem deploying to beta-sepolia May 16, 2024 04:23 — with GitHub Actions Failure

bonnie57 temporarily deployed to external May 16, 2024 05:51 — with GitHub Actions Inactive

bonnie57 added 11 commits May 17, 2024 13:40

Bump version to 1.0.0-rc.12

5228e89

Complete dispute integration tests

0628238

Fix issue issue about PIL_TYPE type

2ec9686

Import type from index in integration tests

c6f31fc

Clean up env variables and create a new env.example file

4fe0c95

Fix issue about commercialRevShare

03eb52c

Remove resolve dispute in integration test and modify env example file

d2d75ee

Integrate signature in ipAsset

8d987e3

Update README.md and delete makefile to update smart contract method

f4a6347

Update pnpm-lock.yaml

ebcc653

Fix RPC in the integration test

c288007

bonnie57 force-pushed the dev branch from 909dcdc to c288007 Compare May 17, 2024 05:41

bonnie57 had a problem deploying to external May 17, 2024 05:41 — with GitHub Actions Failure

Remove ipAccount reference in IpAsset module

ac4e42a

bonnie57 temporarily deployed to external May 17, 2024 08:54 — with GitHub Actions Inactive

bonnie57 had a problem deploying to external May 17, 2024 08:54 — with GitHub Actions Failure

bonnie57 had a problem deploying to beta-sepolia May 17, 2024 17:29 — with GitHub Actions Failure

Replace localhost with 127.0.0.1

da80bd4

bonnie57 temporarily deployed to external May 20, 2024 00:40 — with GitHub Actions Inactive

bonnie57 temporarily deployed to external May 20, 2024 00:41 — with GitHub Actions Inactive

bonnie57 temporarily deployed to beta-sepolia May 20, 2024 00:45 — with GitHub Actions Inactive

bonnie57 had a problem deploying to beta-sepolia May 20, 2024 01:00 — with GitHub Actions Failure

bonnie57 temporarily deployed to external May 20, 2024 19:55 — with GitHub Actions Inactive

bonnie57 had a problem deploying to beta-sepolia May 20, 2024 19:55 — with GitHub Actions Failure

Skip ipAccount.executeWithSig

0f2403d

bonnie57 deployed to external May 21, 2024 01:44 — with GitHub Actions Active

bonnie57 temporarily deployed to beta-sepolia May 21, 2024 17:15 — with GitHub Actions Inactive

edisonz0718 approved these changes May 21, 2024

View reviewed changes

edisonz0718 merged commit b8f4b7a into storyprotocol:dev May 21, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor metadata param in spg #178

Refactor metadata param in spg #178

bonnie57 commented May 13, 2024 •

edited

Loading

Refactor metadata param in spg #178

Refactor metadata param in spg #178

Conversation

bonnie57 commented May 13, 2024 • edited Loading

Description

Test Plan

bonnie57 commented May 13, 2024 •

edited

Loading