Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPG Initialization #161

Closed
wants to merge 9 commits into from
Closed

SPG Initialization #161

wants to merge 9 commits into from

Conversation

jdubpark
Copy link
Contributor

@jdubpark jdubpark commented May 4, 2024

Description

  1. Add periphery repo ABI & wagmi generation
  2. Add the new resource, SPG Client, for SPG-specific functions (currently only createCollection)
  3. Modify existing SPG test to create a collection before SPG-based IPA tests -> make the initial test case work.

Test Plan

  1. In ipAsset.test.ts, create an SPG NFT collection using the SPG Client before executing SPG-related IPA tests.

jacob-tucker and others added 9 commits April 25, 2024 15:42
@jacob-tucker
small fixes (#154)
6ab3b9f
@bonnie57 @edisonz0718
Fix two issues including getLicenseTerms and claimRevenue by EOA (#159)
52719cf 
* Update integration test exclude ipAccount and dispute

* Update contract address about spg

* Extract getLicenseTermsByType method

* Add registerDerivativeIp and mintAndRegisterIpAndAttachPilTerms method

* Add getLicenseTerms methods

* Add claimRevenue by EOA

* Bump version to 1.0.0-rc.7

* Add validate address by calling getAddress

* Add unit tests about getLicenseTermByType

* Fix tests

---------

Co-authored-by: Ze <[email protected]>
@jdubpark
config: periphery repo ABI generation
d6478bf
@jdubpark
feat: add all SPG fns & events
a618dd4
@jdubpark
config: add es2015 for promise in tsconfig
165d96c
@jdubpark
feat: new generated wagmi binding
62502ad
@jdubpark
feat: SPG resource
51c0d80
@jdubpark
fix(test): basic single SPG test case
4d6b07c
@jdubpark
fix: remove test only
0919b69
@jdubpark jdubpark closed this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonFungible DonFungible Awaiting requested review from DonFungible DonFungible is a code owner

@edisonz0718 edisonz0718 Awaiting requested review from edisonz0718 edisonz0718 is a code owner

@jacob-tucker jacob-tucker Awaiting requested review from jacob-tucker jacob-tucker is a code owner

@AndyBoWu AndyBoWu Awaiting requested review from AndyBoWu AndyBoWu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdubpark @jacob-tucker @bonnie57