feat(license attachment): add permission handling in registerPILTermsAndAttach #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsadface
requested review from
kingster-will,
Spablob and
LeoHChen
as code owners
sebsadface
changed the title
registerPILTermsAndAttach
sebsadface
changed the title
registerPILTermsAndAttach
kingster-will
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
registerPILTermsAndAttachfunction inLicenseAttachmentWorkflowsto streamline permission handling. Previously, the caller needed to manually set permission forLicenseAttachmentWorkflowsto invoke theattachLicenseTermsfunction in theLicensingModule. Now, this permission is automatically set within the function, using the provided signature.Key Changes
setPermissionForModule, which grants the required permission to callattachLicenseTermson behalf of the IP.registerPILTermsAndAttachto pass the signature required for setting the permission.Test Plan
All existing tests have been updated and are passing locally.
Related Issue