Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(metadata): merge nftMetadata into struct IPMetadata #37

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

sebsadface
Copy link
Member

Description

This PR merges nftMetadata into struct IPMetadata for better readability and parameter handling. The updated IPMetadata struct is:

struct IPMetadata {
  string ipMetadataURI;
  bytes32 ipMetadataHash;
  string nftMetadataURI;
  bytes32 nftMetadataHash;
}

Key Changes

  • Refactor SPG function parameters to use the merged IPMetadata struct.
  • Update parameter names in SPGNFT for consistency.
  • Update tests to align with the new SPG function parameters.

Test Plan

All existing tests pass locally.

Notes

This change affects the IStoryProtocolGateway interface. Make sure all function calls are updated accordingly.

@sebsadface sebsadface marked this pull request as ready for review August 23, 2024 18:59
@kingster-will kingster-will merged commit 93d64f8 into storyprotocol:main Aug 23, 2024
3 checks passed
@sebsadface sebsadface deleted the metadata-change branch August 28, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants