Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing comments, remove redundant assertion & create3 deployer #32

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

sebsadface
Copy link
Member

Description

This PR introduces the following minor updates:

  • Added missing parameter comments to SPG and its interface.
  • Removed a redundant assert statement from SPG tests.
  • Removed the unnecessary Create3 deployer from the SPGNFT upgrade script.

@kingster-will kingster-will merged commit ac66aa9 into storyprotocol:main Aug 20, 2024
3 checks passed
@sebsadface sebsadface deleted the chore branch August 28, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants