Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OrgStoryNFTFactory Contract to Reduce Code Redundancy #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukema95
Copy link

Description

This PR refactors the OrgStoryNFTFactory.sol contract to reduce code redundancy and improve code readability and maintainability.

  1. Extracted Common Functions:
    Extracted repeated logic from deployOrgStoryNft and deployOrgStoryNftByAdmin into two new private functions:
    _validateSignature: Handles signature validation.
    _deployOrgStoryNft: Executes the actual NFT deployment logic.

  2. Code Optimization:
    Reduced duplicate code, enhancing readability and maintainability.
    Ensured all signature validation and NFT deployment logic is centralized, minimizing potential errors and inconsistencies.

Test Plan

All unit tests passed

Related Issue

Notes

@sebsadface
Copy link
Member

Hi @lukema95, Thank you for your contribution! We have a requirement for all commits to have verified signatures before merging. To resolve this, please ensure your commits are signed.

You can follow GitHub's guide on signing commits to set this up.

Thanks again for your work on this! 😊

@lukema95
Copy link
Author

lukema95 commented Jan 4, 2025

Hi @lukema95, Thank you for your contribution! We have a requirement for all commits to have verified signatures before merging. To resolve this, please ensure your commits are signed.

You can follow GitHub's guide on signing commits to set this up.

Thanks again for your work on this! 😊

done 😊

Copy link
Member

@sebsadface sebsadface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants