Refactor OrgStoryNFTFactory Contract to Reduce Code Redundancy #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the OrgStoryNFTFactory.sol contract to reduce code redundancy and improve code readability and maintainability.
Extracted Common Functions:
Extracted repeated logic from
deployOrgStoryNft
anddeployOrgStoryNftByAdmin
into two new private functions:_validateSignature
: Handles signature validation._deployOrgStoryNft
: Executes the actual NFT deployment logic.Code Optimization:
Reduced duplicate code, enhancing readability and maintainability.
Ensured all signature validation and NFT deployment logic is centralized, minimizing potential errors and inconsistencies.
Test Plan
All unit tests passed
Related Issue
Notes