Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deriv): restore v1.2 compatibility to DerivativeWorkflows #147

Merged

Conversation

sebsadface
Copy link
Member

Description

This PR reintroduces compatibility with protocol periphery v1.2 in DerivativeWorkflows. The v1.2 interface has been restored, with updated function implementations to ensure compatibility with protocol core v1.3.

Test Plan

Restored and updated the test cases for the v1.2 interface. All tests passes locally.

Related Issue

Notes

Downstream integrations should now use the added MakeDerivativeDEPR struct (for v1.2 compatibility) in WorkflowStructs instead of the MakeDerivative struct (specific to v1.3). No additional changes are required.

@sebsadface sebsadface merged commit 7c3c545 into storyprotocol:main Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants