fix(licensing): ensure empty license data arrays are rejected #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsadface
requested review from
kingster-will,
Spablob and
LeoHChen
as code owners
kingster-will
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces checks to ensure functions with multi-license attachment features properly handle empty license data arrays. The affected functions will now revert if the provided license data array is empty.
The updated functions include:
mintAndRegisterIpAndAttachLicenseAndAddToGroupregisterIpAndAttachLicenseAndAddToGroupregisterPILTermsAndAttachmintAndRegisterIpAndAttachPILTermsregisterIpAndAttachPILTermsTest Plan
New test cases have been added to confirm that each of the affected functions reverts when an empty license data array is passed.