feat(licensing): add maxRevenueShare parameter to align with core protocol changes
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsadface
requested review from
kingster-will,
Spablob and
LeoHChen
as code owners
|
Do we provide an interface without the new parameters, so that application integrated with 1.2 api won't need to be changed? |
kingster-will
approved these changes
Dec 16, 2024
The plan is to add backward compatibility all together in a separate PR, we have an issue tracking this: #131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
maxRevenueShareparameter to functions and tests related to derivative registration and license token minting, aligning with changes introduced in Core Protocol PR#364.The
maxRevenueShareparameter enables users to define the maximum royalty percentage they are willing to accept when minting license tokens or registering derivatives to parent IPs. This enhancement improves user control and flexibility in licensing agreements.