This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Adds IP registry and metadata resolver #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoHChen
reviewed
Jan 20, 2024
LeoHChen
reviewed
Jan 20, 2024
LeoHChen
reviewed
Jan 20, 2024
Ramarti
approved these changes
Jan 20, 2024
LeoHChen
reviewed
Jan 20, 2024
kingster-will
approved these changes
Jan 20, 2024
LeoHChen
reviewed
Jan 20, 2024
jdubpark
approved these changes
Jan 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new IP registry and IP resolver layer for Story Protocol.
Note that the IP registry purposely disambiguates between the IP account and the IP identifier, despite these two entities currently being equivalent. The reason for this is in case we decide to further decouple the two entities later on, or if we want to support the notion of multiple IP accounts in the future. By allowing this separation, we reduce friction for future protocol authorization endeavors.
This PR also achieves 100% test coverage on both the registry and resolver sides.
NOTE: The core workflow of registration will be introduced in a separate PR.