This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
generated from storyprotocol/solidity-template
-
Notifications
You must be signed in to change notification settings - Fork 121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If |
LeoHChen
reviewed
Jan 26, 2024
LeoHChen
reviewed
Jan 26, 2024
…s, more base contract, test fixes
leeren
reviewed
Jan 27, 2024
leeren
approved these changes
Jan 27, 2024
jdubpark
added a commit
that referenced
this pull request
Jan 27, 2024
* feat: foundry deploy script w/ hardhat wip * feat: fix foundry deploy script * feat: makefile abi & typechain * feat: hardhat scripts * fix: delete ignore folder * feat: script deployments and mocks * fix: package deps * fix: ignore folders * feat: deploy & revert scripts * feat: tagging module events (#26) * feat: main deploy configs & minor makefile change * additional deploy & post-deploy scripts * hardhat config * fix: deploy scripts for new interfaces & structs * merge main * fix: modify script for new merged main * fix: remove unused files & modify script/configs * Introducing Meta-Transaction Support to IPAccount with EIP712 Standard Signatures (#32) * Parameters (#31) * added transfer terms, refactored term checking * add param test * unused var test * fix policy needs transfer arguments * fix tests, addPolicy public only allow new policies * licenseData not provided when minting, it is a result * added activation * wip: license activation * rolled back license status * removed activation related code * stray activation method * stray event * stray errors * fix comment * fix comment * WIP * comment * fixes * WIP * WIP: fix identification of policy set by linking * refactor to compile * fix except integration * feat: integration test fix, remove local vars, add reverts on verification * fix: verifier interfaces, integration test fix, mock verifier fix, remove local var * fix: rename contract, add constructor param for mock verifier, formats, more base contract, test fixes * fix: rename vars and clean stack * feat: flexible MockParamVerifier, modify integration/unit test runs * Update contracts/interfaces/licensing/IMintParamVerifier.sol --------- Co-authored-by: Raul <[email protected]> Co-authored-by: Jongwon Park <[email protected]> * fix: remove lcov.info --------- Co-authored-by: kingster-will <[email protected]> Co-authored-by: Ramarti <[email protected]> Co-authored-by: Raul <[email protected]>
LeoHChen
reviewed
Jan 27, 2024
@@ -0,0 +1,168 @@ | |||
// // SPDX-License-Identifier: UNLICENSED | |||
|
|||
pragma solidity ^0.8.23; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why check-in code with everything commented out? can you leave those code in your local branch?
LeoHChen
reviewed
Jan 27, 2024
function verifyActivation(address, bytes memory) external pure returns (bool) { | ||
return true; | ||
} | ||
function verifyActivation(address, bytes memory) external pure returns (bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linting please
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors to run parameter verifiers:
Instead of having several arrays of parameters, like mintParamVerifiers, transferParamVerifiers, etc, we have 1 array of parameters, since we can't affirm that a parameter wont have to check only process in the life cycle.
We store them in a mapping by name in the framework, since some parameters have to check other parameters potentially.
Every parameter must implement IParameterVerifier, but they can chose if they implement IMintParamVerifier, ILinkParamVerifier... they will be called if they are included in the policy, when they are needed, thanks to ERC165. If the parameter doesn't implement those interfaces, it's a purely "data" parameter, where we can just set the value. TODO: compatibility checks for those
Since in UML there are complex parameters that depend on one another, I simplified the implementation with:
We also simplify licensing by allowing only 1 licensor per LNFT