Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Feat/optimize ci workflow #144

Closed
wants to merge 15 commits into from
Closed

Feat/optimize ci workflow #144

wants to merge 15 commits into from

Conversation

AndyBoWu
Copy link
Contributor

Some notes:

  1. add job timestamp
  2. pinpoint checkout version
  3. remove junk code (list files, print out env variables, not being used jobs ...)
  4. remove unnecessary env variables in the workflow

Spablob and others added 15 commits February 28, 2024 08:52
@Spablob
Simplify royalty logic (#1)
a9f5a2a 
* Fix PolicyInitialized event

* remove withdrawETH for code simplification and clarity

* change RNFT recipient to IPAccount instead of IP Pool + remove withdrawETH from ancestors vault
@jdubpark
feat: deprecate registration module (#3)
a5ad816
@Spablob
remove ancestors hash from LAP royalty policy
492dc76
@Spablob
format adjustments on LAP policy contract
0bc2892
@Spablob
add ancestors vault claim function adjustments
ee44ecb
@Spablob
fix errors.sol
0c5d69c
@Spablob
add script and test adjustments
9e24213
@kingster-will
Introducing IPAccount Namespace Storage and IViewModule for Enhanced …
bbd1c11 
…Metadata Display (#2)

* IPAccount storage impl

* emit old IPRegistered event

* add premissionless register() function into IIPAssetRegistry interface

* reduce setter/getter in IPAccountStorage Interface
@Spablob
minor fix in script
62aa723
@Spablob
gas fix
31917e6
@Spablob
Merge branch 'storyprotocol:main' into remove-hash-lap
c233208
@jdubpark
Merge pull request #4 from Spablob/remove-hash-lap
691994e 
Remove ancestors hash and royalty context requirement from royalty LAP policy
@Ramarti
Tooling for upgradeable contracts (#6)
d826433 
* upgrades plugin and upgradeable LicenseRegistry

* add .gitmodules

* remove forge install oz upgrades in gha

* use TestProxyHelper in tests instead of upgrades

* no need for --ffi in tests
@Ramarti
Remove oz storage checks from GHA (#10)
bf49b64 
* remove oz foundry lib from gha build

* remove duplicated gha code, remove forge install oz upgrade lib

* use test deploy proxy helper to unblock
@AndyBoWu
[feat] optimize the CI workflow
ea29d09
@AndyBoWu AndyBoWu requested a review from jdubpark March 21, 2024 23:06
@AndyBoWu AndyBoWu closed this Mar 21, 2024
@openzeppelin-code OpenZeppelin Code
Copy link

Feat/optimize ci workflow

Generated at commit: ea29d09aa2ab1d0756422e2b3dfa385f3c960765

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
1
0
5
33
41
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
1
0
1

For more details view the full report in OpenZeppelin Code Inspector

@LeoHChen LeoHChen deleted the feat/optimize_ci_workflow branch March 21, 2024 23:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jdubpark jdubpark Awaiting requested review from jdubpark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AndyBoWu @Spablob @jdubpark @kingster-will @Ramarti