Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Add permissions for the IPA registry to call linkParentToIp in the licensing module #102

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Add permissions for the IPA registry to call linkParentToIp in the licensing module #102

merged 1 commit into from
Feb 16, 2024

Conversation

leeren
Copy link
Contributor

@leeren leeren commented Feb 16, 2024

This change ensures that the IPA registry has permissions to call the licensing module's linkParentToIp function, so that when users perform derivative registration via the IPA registry, the registry will be allowed to link the derivative IPA to its parent.

Copy link
Contributor

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does it mean by permissionless remixing?

@leeren leeren changed the title Add global licensing permissions for remixing to the IPA registry in the deployment script Add permissions for the IPA registry to call linkParentToIp in the licensing module Feb 16, 2024
@leeren
Copy link
Contributor Author

leeren commented Feb 16, 2024

what does it mean by permissionless remixing?

As in, just like how anyone can call the IPA registry to register their IP, anyone should be able to call the IPA registry to register their IP as a derivative. Until now, we've solely relied on the registration module for doing all of this (which will be phased out at a later point in time), but the idea is that the IPA registry is permissionless and users should be able to do the same by calling the registry directly. I updated the language to make it clearer.

@LeoHChen
Copy link
Contributor

what does it mean by permissionless remixing?

As in, just like how anyone can call the IPA registry to register their IP, anyone should be able to call the IPA registry to register their IP as a derivative. Until now, we've solely relied on the registration module for doing all of this (which will be phased out at a later point in time), but the idea is that the IPA registry is permissionless and users should be able to do the same by calling the registry directly. I updated the language to make it clearer.

Not sure if we allow anyone to register their IP as a derivative. I think this breaks our ip graph creation and licensing requirement. I would hold this PR.

@jdubpark
Copy link
Contributor

We are now allowing IPAssetRegistry to call into LicensingModule for linkIpToParents, previously only allowed for RegistrationModule. As long as you (child) own the licenses, it can now call through either IPAssetRegistry or RegistrationModule to link to a parent.

LicensingModule does the permission check

function linkIpToParents(
    uint256[] calldata licenseIds,
    address childIpId,
    bytes calldata royaltyContext
) external nonReentrant verifyPermission(childIpId) { ... }

@LeoHChen LeoHChen merged commit 4373a6d into storyprotocol:main Feb 16, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants