forked from storyprotocol/protocol-core
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored to upgradeable contracts (2/2) (Dispute, Royalties) #8
Merged
Ramarti
merged 20 commits into
storyprotocol:main
from
Ramarti:rest-upgradeable-contracts
Mar 25, 2024
Merged
Refactored to upgradeable contracts (2/2) (Dispute, Royalties) #8
Ramarti
merged 20 commits into
storyprotocol:main
from
Ramarti:rest-upgradeable-contracts
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramarti
force-pushed
the
rest-upgradeable-contracts
branch
from
March 20, 2024 01:02
dd7bc99
to
4e66138
Compare
Ramarti
changed the title
Refactored Dispute and Royalty contracts for upgradeability
Refactored to upgradeable contracts (2/2) (Dispute, Royalties)
Mar 20, 2024
Ramarti
force-pushed
the
rest-upgradeable-contracts
branch
from
March 22, 2024 23:37
3931f2c
to
f930680
Compare
Ramarti
requested review from
kingster-will,
leeren,
jdubpark,
Spablob,
LeoHChen and
AndyBoWu
as code owners
March 22, 2024 23:37
Ramarti
force-pushed
the
rest-upgradeable-contracts
branch
2 times, most recently
from
March 24, 2024 00:09
8f3bc23
to
c896aac
Compare
Ramarti
force-pushed
the
rest-upgradeable-contracts
branch
from
March 24, 2024 21:38
c896aac
to
6705978
Compare
Spablob
reviewed
Mar 25, 2024
Spablob
reviewed
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Spablob
approved these changes
Mar 25, 2024
jdubpark
approved these changes
Mar 25, 2024
kingster-will
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: sequential PR after #7
Not in this PR:
AncestorsVault, we are deciding if we need it