Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored to upgradeable contracts (2/2) (Dispute, Royalties) #8

Merged
merged 20 commits into from
Mar 25, 2024

Conversation

Ramarti
Copy link

@Ramarti Ramarti commented Mar 18, 2024

Note: sequential PR after #7

  • Dispute
  • ArbitrationPolicySP
  • RoyaltyModule
  • RoyaltyPolicyLAP

Not in this PR:
AncestorsVault, we are deciding if we need it

@Ramarti Ramarti force-pushed the rest-upgradeable-contracts branch from dd7bc99 to 4e66138 Compare March 20, 2024 01:02
@Ramarti Ramarti changed the title Refactored Dispute and Royalty contracts for upgradeability Refactored to upgradeable contracts (2/2) (Dispute, Royalties) Mar 20, 2024
@Ramarti Ramarti marked this pull request as ready for review March 20, 2024 23:05
@Ramarti Ramarti force-pushed the rest-upgradeable-contracts branch from 3931f2c to f930680 Compare March 22, 2024 23:37
@Ramarti Ramarti force-pushed the rest-upgradeable-contracts branch 2 times, most recently from 8f3bc23 to c896aac Compare March 24, 2024 00:09
@Ramarti Ramarti force-pushed the rest-upgradeable-contracts branch from c896aac to 6705978 Compare March 24, 2024 21:38
Copy link

@Spablob Spablob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ramarti Ramarti merged commit 89fe9c5 into storyprotocol:main Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants