Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add More Validations to Group IPA #358

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

kingster-will
Copy link

Description

This PR introduces additional validations to the Group IPA to ensure consistency and integrity in the licensing process. The changes include restrictions on attaching license terms, requirements for adding IPs to a group, and freezing certain license configuration items once the group has its first member.

Key Changes

  • Single License Term Validation: Ensures that a Group IPA can only attach one license term, which must be common to all members.
  • Consistent License Config Validation: When adding an IP to a Group, the Group and IP must have the same mintingFee and licenseHook in the LicenseConfig. Additionally, the Group's commercial revenue share must be greater than or equal to the IP's commercial revenue share.
  • Freezing License Config Items: Once a Group has its first member, the mintingFee, licensingHook, and licensingHookData are frozen. The Group's commercial revenue share can only increase.

Objectives

  • Ensure Consistency: Prevent Group IPAs from attaching more than one license term and ensure consistent license configurations when adding IPs to a Group.
  • Maintain Integrity: Freeze certain license configuration items once the Group has its first member to maintain the integrity of the Group's licensing process.

Closes https://github.com/storyprotocol/trust-protocol-contracts-v1/issues/7

@kingster-will kingster-will merged commit d2281f5 into storyprotocol:main Dec 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants