Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from _mint() to _safeMint() for Minting Group NFTs #349

Merged

Conversation

kingster-will
Copy link

Description

This PR updates the GroupNFT contract to use _safeMint() instead of _mint() when minting Group NFTs. This change ensures that the receiver can handle the NFT properly by checking if the receiver is a contract and if it implements the IERC721Receiver interface.

Key Changes

  • Minting Method Update: Replaced _mint() with _safeMint() in the GroupingModule contract for minting Group NFTs.

Closes https://github.com/FuzzingLabs/story-audit-monorepo/issues/3

Copy link
Member

@sebsadface sebsadface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@kingster-will kingster-will merged commit fe111b6 into storyprotocol:main Dec 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants