Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented gas difference and code coverage for now #154

Merged

Conversation

Ramarti
Copy link
Contributor

@Ramarti Ramarti commented Nov 1, 2023

So module tests are skipped until refactor

@LeoHChen
Copy link
Member

LeoHChen commented Nov 1, 2023

I guess we just need to update github Action to skip those tests. no need to update the code. @kingster-will

@Ramarti
Copy link
Contributor Author

Ramarti commented Nov 1, 2023

I guess we just need to update github Action to skip those tests. no need to update the code. @kingster-will

GHAction takes config from a file in the repo, AFAIK

@kingster-will
Copy link
Contributor

I guess we just need to update github Action to skip those tests. no need to update the code. @kingster-will

GHAction takes config from a file in the repo, AFAIK

I think it is due to github action event is pull_request_target which would run the github workflow within target repo (protocol-contracts) rather than the forked repo of the PR.

Created a PR to change event to pull_request, it should resolve the issue.
#155

@kingster-will kingster-will merged commit d7967d0 into storyprotocol:main Nov 1, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants