-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base module #149
Base module #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General Looks good to me!
a few comments.
I think we can merge the PR, as the unit tests have passed actually. the github workflow failed due to code coverage which has been commented out in another PR. |
Merging with main was needed to pass the tests |
HookRegistry: logic and state for Modules to manage hooks
BaseModule: Module execution flow
Closes #145