Add convenience scripts and fix deployment issues. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds collect payment module * Finalize all payment collect module testing * Adds more comments * Updates lock * NPM package incorrectly removed * NPM package incorrectly removed * Try fixing npm bug again
* added no unused importa and vars, updated solhint * removed solhint errors * change from npm to yarn * fix errors --------- Co-authored-by: Raul <[email protected]>
* wip * refactored interfaces * lint * added natspec --------- Co-authored-by: Raul <[email protected]>
* wip * refactored interfaces * lint * wip * moar refactor --------- Co-authored-by: Raul <[email protected]>
* wip * refactored interfaces * lint * wip * moar refactor * refactor natspec to triple slash * lint --------- Co-authored-by: Raul <[email protected]>
* refactoring param names * more underscores --------- Co-authored-by: Raul <[email protected]>
Adds modular refactoring of errors and structs
* Reorder functions by follow official solidity style guide
Summary:
Functions are grouped according to their visibility and ordered:
constructor
receive function (if exists)
fallback function (if exists)
external
public
internal
private
Within a grouping, place the view and pure functions last.
Co-authored-by: Raul <[email protected]>
|
Mistakenly merged main to this. Replaced by #132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not modify the contracts, so it will not bump versions