Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds standard collect events #126

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

leeren
Copy link
Contributor

@leeren leeren commented Oct 11, 2023

Fixes #85 by adding two standard Collect events:

One for invocation of the Collect action:

    event Collected(
        uint256 indexed franchiseid_,
        uint256 indexed ipAssetId_,
        address indexed collector_,
        address collectNft_,
        uint256 collectNftId_,
        bytes collectData_,
        bytes collectNftData_
    );

And one for deploying a new Collect NFT:

    /// @dev Emits when a new collect NFT is deployed.
    event NewCollectNFT(
        uint256 indexed franchiseId_,
        uint256 indexed ipAssetId_,
        address collectNFT_
    );

@leeren leeren self-assigned this Oct 11, 2023
Copy link
Contributor

@kingster-will kingster-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@leeren leeren merged commit bfe06bc into storyprotocol:main Oct 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize collect module events
2 participants