Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated solhint with new rules, cleared errors. #112

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Updated solhint with new rules, cleared errors. #112

merged 4 commits into from
Sep 29, 2023

Conversation

Ramarti
Copy link
Contributor

@Ramarti Ramarti commented Sep 29, 2023

  • Updated solhint to 3.6.2

  • Added or modified this settings to solhint

"compiler-version": ["error", ">=0.8.0"],
"no-unused-import": "error",
"no-unused-vars": "error",
"no-inline-assembly": "off",
"avoid-low-level-calls": "off",
"no-global-import": "error",
  • Added to prettier
"bracketSpacing": true
  • Modified code to pass solhint errors, NOT prettier

@Ramarti Ramarti requested review from kingster-will and leeren and removed request for kingster-will September 29, 2023 15:31
kingster-will
kingster-will approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@kingster-will kingster-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

leeren
leeren approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@leeren leeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ramarti Ramarti merged commit 06a546d into main Sep 29, 2023
@LeoHChen LeoHChen deleted the code_style/unused_imports branch September 29, 2023 19:13
@Ramarti Ramarti mentioned this pull request Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingster-will kingster-will kingster-will approved these changes

@leeren leeren leeren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ramarti @leeren @kingster-will