Skip to content

Commit

Permalink
inconsistency in licensing roles
Browse files Browse the repository at this point in the history
  • Loading branch information
Raul committed Dec 18, 2023
1 parent 400ffbf commit dca06a5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions contracts/lib/AccessControl.sol
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,4 @@ library AccessControl {
// Role that can execute Hooks
bytes32 public constant HOOK_CALLER_ROLE = keccak256("HOOK_CALLER_ROLE");

// Role to set legal terms in TermsRepository
bytes32 public constant LICENSING_MANAGER = keccak256("LICENSING_MANAGER");
}
2 changes: 1 addition & 1 deletion contracts/modules/licensing/LicensingFrameworkRepo.sol
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ contract LicensingFrameworkRepo is AccessControlled, Multicall {
/// @dev this is an admin only function, and can only be called by the
/// licensing manager role
/// @param input_ the input parameters for the framework
function addFramework(Licensing.SetFramework calldata input_) external onlyRole(AccessControl.LICENSING_MANAGER) {
function addFramework(Licensing.SetFramework calldata input_) external onlyRole(AccessControl.LICENSING_MANAGER_ROLE) {
FrameworkStorage storage framework = _frameworks[input_.id];
if (framework.paramTags.length() > 0) {
revert Errors.LicensingFrameworkRepo_FrameworkAlreadyAdded();
Expand Down

0 comments on commit dca06a5

Please sign in to comment.