Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless steps and secrets in reusable-build-test-workflow.yml #99

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Remove useless steps and secrets in reusable-build-test-workflow.yml #99

merged 1 commit into from
Dec 6, 2024

Conversation

bonnie57
Copy link
Contributor

@bonnie57 bonnie57 commented Dec 5, 2024

Description

  • SDK has some updates about secrets, so we need to remove useless secrets to keep them clean.
  • Because of smart contract limitation, we cannot fork Odyssey by foundry.

AndyBoWu
AndyBoWu approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@AndyBoWu AndyBoWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The only concern is that I am 100% sure if any others gha workflow are calling this reusable workflow

@AndyBoWu AndyBoWu merged commit 86c8d11 into storyprotocol:main Dec 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyBoWu AndyBoWu AndyBoWu approved these changes

@wo-o wo-o Awaiting requested review from wo-o wo-o is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonnie57 @AndyBoWu