-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tag name input to create github release reusable workflow #72
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis update introduces new reusable workflow configurations to enhance the automation capabilities in CI/CD processes. We see additions like input parameters for tagging releases, reusable workflows for secret scanning, Go linting, and timestamp management. This streamline workflow setup ensures ease of maintenance and scalability. Changes
Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- .github/workflows/reusable-create-release.yml (2 hunks)
- docs/security/readme-reusable-secrets-scanning.md (1 hunks)
- docs/utility/readme-reusable-lint-go-workflow.md (1 hunks)
- docs/utility/readme-reusable-timestamp.md (1 hunks)
Additional context used
Markdownlint
docs/utility/readme-reusable-lint-go-workflow.md
9-9: Expected: 0; Actual: 1
Unordered list indentation(MD007, ul-indent)
17-17: Expected: 0; Actual: 1
Unordered list indentation(MD007, ul-indent)
docs/utility/readme-reusable-timestamp.md
9-9: Expected: 0; Actual: 1
Unordered list indentation(MD007, ul-indent)
docs/security/readme-reusable-secrets-scanning.md
9-9: Expected: 0; Actual: 1
Unordered list indentation(MD007, ul-indent)
Additional comments not posted (1)
.github/workflows/reusable-create-release.yml (1)
10-13
: Ensure the new input parameter is utilized correctly.The new input parameter
tag_to_publish
is introduced. Verify that it is used correctly in the workflow.
|
||
## Secrets | ||
|
||
- N/A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix unordered list indentation.
The unordered list should have consistent indentation.
- - N/A
+ - N/A
Committable suggestion was skipped due to low confidence.
Tools
Markdownlint
17-17: Expected: 0; Actual: 1
Unordered list indentation(MD007, ul-indent)
|
||
## Triggers | ||
|
||
- Workflow call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix unordered list indentation.
The unordered list should have consistent indentation.
- - Workflow call
+ - Workflow call
Committable suggestion was skipped due to low confidence.
Tools
Markdownlint
9-9: Expected: 0; Actual: 1
Unordered list indentation(MD007, ul-indent)
|
||
## Triggers | ||
|
||
- Workflow call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix unordered list indentation.
The unordered list should have consistent indentation.
- - Workflow call
+ - Workflow call
Committable suggestion was skipped due to low confidence.
Tools
Markdownlint
9-9: Expected: 0; Actual: 1
Unordered list indentation(MD007, ul-indent)
|
||
## Triggers | ||
|
||
- Workflow Call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix unordered list indentation.
The unordered list should have consistent indentation.
- - Workflow Call
+ - Workflow Call
Committable suggestion was skipped due to low confidence.
Tools
Markdownlint
9-9: Expected: 0; Actual: 1
Unordered list indentation(MD007, ul-indent)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/reusable-create-release.yml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/reusable-create-release.yml
Description
Added tag name input for reusable-create-release to distinguish between different releases. Updated documentation for several workflows.
Test Plan
Example:
Related Issue
Example: Issue #123
Notes
Summary by CodeRabbit
Documentation
Chores
tag_to_publish
for specifying the tag name to be published.