Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin/bpolania/workflows #100

Merged
merged 19 commits into from
Dec 10, 2024
Merged

Origin/bpolania/workflows #100

merged 19 commits into from
Dec 10, 2024

Conversation

bpolania
Copy link
Collaborator

Description

This is an update aiming to improve SDK's workflows, with the final objective of separating unit and integration tests, so the latest can be run after the merge.

  • Two new workflows were created to deal with unit and integration tests separately.
    • reusable-build-unit-test-workflow
    • reusable-build-integration-test-workflow
  • Original reusable-build-test-workflow is not being deleted because it will might disrupt flows outside the SDK workflows.
  • Removed unused comments.

Test Plan

These workflows can be tested by making PR to the /origin/dev-polania/workflows branch of the SDK repo. It will trigger the two new workflows.

Copy link
Contributor

@AndyBoWu AndyBoWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Did you get a chance test this reusable workflow yet?

@bpolania bpolania merged commit d6ee6e0 into main Dec 10, 2024
1 check passed
@bpolania bpolania deleted the origin/bpolania/workflows branch December 10, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants