Bug: fix pnp; add auto-detection for pnp in CLI; not destroy pnp in sandbox script #21089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
added
bug
ci:daily
ndelangen
force-pushed
the
norbert/pnp-fixes
branch
from
fa39c38 to
62e37c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20405
Add auto-detection for pnp mode in
storybook initCLI.Also fix an critical issue where when pnp is enabled, the storybook CLI cannot find the renderer package; which it needs to copy templates from, into the user's newly created project, to serve as demo stories.
Related: (possibly fixes these)
#20861
#19764
#18626
#18625
#18435
#21004