Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update handlebars or template to not ignore first param #30

Merged
merged 2 commits into from
Oct 18, 2023
Merged

fix: update handlebars or template to not ignore first param #30

merged 2 commits into from
Oct 18, 2023

Conversation

btkostner
Copy link
Contributor

For some reason this is not templating correctly in our common-config-elixir repository. Debugging.

@btkostner btkostner self-assigned this Oct 17, 2023
@btkostner
Copy link
Contributor Author

Ah, lovely. Failed test. Should be easy to fix (famous last words.)

@btkostner btkostner changed the title chore: add more tests to handlebars helpers fix: update handlebars or template to not ignore first param Oct 17, 2023
@btkostner
Copy link
Contributor Author

I don't know who made this API but having a spread operator and then a static variable is horrible. Should fix issues. Test to confirm.

@btkostner btkostner marked this pull request as ready for review October 17, 2023 18:01
@btkostner btkostner requested a review from a team October 17, 2023 18:01
@btkostner btkostner merged commit 91d84af into main Oct 18, 2023
4 checks passed
@btkostner btkostner deleted the btkostner-patch-1 branch October 18, 2023 13:33
@stord-engineering-account stord-engineering-account mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkerd parkerd parkerd approved these changes

Assignees

@btkostner btkostner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btkostner @parkerd