Avoid some tracebacks during populate #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a new flag to control this behavior: allow_inconsistent_config. When False, DuplicateUUIDError will be raised when trying to add any subsequent device whose UUID matches one already in the tree. When True, the duplicate UUIDs will be allowed to coexist until/unless a call to DeviceTree.get_device_by_uuid is made with the duplicate UUID as its argument. In this case, DuplicateUUIDError will be raised.
The goal here is to absolutely minimize tracebacks that occur when populating the devicetree. There are mechanisms in place that will limit the supported functionality for managing such devices, but there will be no tracebacks until/unless the user tries to manage them in ways that are precluded by the detection issues previously encountered.
Co-authored-by: Vojtech Trefny <[email protected]>
Co-authored-by: Vojtech Trefny <[email protected]>
This was referenced Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.