ACM-13003-Fast-cluster-page-load

[jeswanke]

1. environment label MOCK_CLUSTERS="number" in order to mock that many clusters and
   3 policies and
   44 system apps for each cluster
2. that context error you found was caused by trying to use PluginContext in acm (mce only it looks like)
3. there's a new LoadStatusProvider that any plugin can use that tells at what stage LoadData is:
   loadStarted --> the first packet has been received, if the data for that page is in the first packet it can start displaying
   loadCompleted --> the load of all data is done (the old loaded context value)

the first packets are these:
case 'ManagedCluster':
case 'HostedCluster':
case 'ClusterDeployment':
case 'Policy':
case 'PolicySet':
case 'AgentClusterInstall':
case 'ManagedClusterInfo':
case 'ManagedClusterAddOn':
case 'Search':
case 'Secret':

Signed-off-by: John Swanke [email protected]

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeswanke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jeswanke]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jeswanke]

/test unit-tests-sonarcloud

[jeswanke]

/test unit-tests-sonarcloud

[KevinFCormier]

Noted a bad import here. I will ping you separately about another change, and then re-test. Aiming to deliver this on Thursday (start of Train-22).

[jeswanke]

/test unit-tests-sonarcloud

[KevinFCormier]

/hold for Train-22

[KevinFCormier]

Hey John,

I'm seeing some loading issues in places.

Applications, Advanced configuration tab

• All 4 tables show a skeleton indefinitely

Governance, Overview tab

• Shows spinner indefinitely
  Governance, Policies / Discovered policies tabs
• Shows table skeleton indefinitely

[jeswanke]

hey Kevin,

oops I used:
const { loadCompleted } = useContext(PluginDataContext)
instead of:
const { dataContext } = useContext(PluginContext)
const { loadCompleted } = useContext(dataContext)

all better now

[sonarcloud]

Quality Gate failed

Failed conditions
27.4% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

[openshift-ci]

@jeswanke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit-tests-sonarcloud	1a9dba2	link	true	/test unit-tests-sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jeswanke]

/test console-acm-213-on-pull-request

[openshift-ci]

@jeswanke: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test check

/test images

/test pr-image-mirror

/test pr-image-mirror-mce

/test unit-tests-sonarcloud

Use /test all to run all jobs.

In response to this:

/test console-acm-213-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.