IngressVIPs for VMW cluster creation #4052
Conversation
Randy424
force-pushed
the
ACM-5590-multi-ingress
branch
2 times, most recently
from
d742601
to
74e4227
Compare
Randy424
requested review from
jeswanke,
zlayne and
KevinFCormier
and removed request for
zlayne
Randy424
force-pushed
the
ACM-5590-multi-ingress
branch
4 times, most recently
from
64c95a3
to
5f0cce1
Compare
|
/hold Not ready for merge yet. Reviewed with @jeswanke. Added a fix for an existing syntax issue. A new reverse update callback for component needs to be implemented, and some more refactoring will be necessary to get it working. |
Signed-off-by: Randy Bruno Piverger <[email protected]>
Randy424
force-pushed
the
ACM-5590-multi-ingress
branch
2 times, most recently
from
cf25219
to
599200e
Compare
| if (editorIndex > 1) { | ||
| otherYAMLTabs[editorIndex - 1].editor = editor | ||
| if (editorIndex >= 1) { | ||
| set(otherYAMLTabs, `${editorIndex - 1}.editor`, this.editors[editorIndex]) |
There was a problem hiding this comment.
@jeswanke here is the fix you asked me to include.
Signed-off-by: Randy Bruno Piverger <[email protected]>
Randy424
force-pushed
the
ACM-5590-multi-ingress
branch
from
599200e
to
79a9b47
Compare
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeswanke, Randy424 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Regarding: https://issues.redhat.com/browse/ACM-5590
Renders IngressVIPs multitext component as default input for VMW cluster creation, and will revert to single text field IngressVIP when selected OpenShift version is less than 4.12.0, which is when support for a list of IngressVIP values began.
HOW TO TEST:
Find yaml sample here.