Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-3456 Governance > Policies > Results tab #3857

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

vishsanghishetty
Copy link
Contributor

@vishsanghishetty vishsanghishetty commented Sep 13, 2024

ACM UI

PR Description

This PR introduces several updates related to localization and date/time formatting in the project, including:
This PR is for ticket
This PR is for ticket

Acceptance Criteria

Acceptance Criteria

Date/Time Formatting:

  • Integrated date and time formatting using Intl.DateTimeFormat for standard date/time formatting.
    Implemented dynamic relative time formatting with Intl.RelativeTimeFormat to handle fromNow functionality in i18n interpolation.

Credentials Page and Governance Policy Results Details:

  • Applied dynamic date localization using i18n for relative time display in the table columns that show timestamps. Replaced moment.js with i18n's interpolation for relative time formatting.

Unit Test Coverage:

Added unit tests to verify:

  • fromNow functionality for relative time formatting.
  • Proper handling of various date and time scenarios.
  • Accurate format function execution within i18n.

Copy link

openshift-ci bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vishsanghishetty
Once this PR has been reviewed and has the lgtm label, please assign randy424 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
@vishsanghishetty

This comment was marked as outdated.

@vishsanghishetty

This comment was marked as outdated.

@vishsanghishetty

This comment was marked as outdated.

@vishsanghishetty

This comment was marked as outdated.

Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
@KevinFCormier
Copy link
Contributor

/hold I am reviewing and anticipate I will want to request some changes.

@vishsanghishetty
Copy link
Contributor Author

/retest

Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
@vishsanghishetty
Copy link
Contributor Author

/retest-required

Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
41.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

Copy link

openshift-ci bot commented Sep 17, 2024

@vishsanghishetty: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-tests-sonarcloud 380881c link true /test unit-tests-sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants