-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACM-3456 Governance > Policies > Results tab #3857
base: main
Are you sure you want to change the base?
ACM-3456 Governance > Policies > Results tab #3857
Conversation
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
…upport Signed-off-by: vsanghishetty <[email protected]>
…mestamps in CredentialsPage Signed-off-by: vsanghishetty <[email protected]>
…mestamps in GovernancePolicyResultstab Signed-off-by: vsanghishetty <[email protected]>
…torage Signed-off-by: vsanghishetty <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vishsanghishetty The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
frontend/src/routes/Governance/policies/policy-details/PolicyDetailsResults.tsx
Outdated
Show resolved
Hide resolved
frontend/src/routes/Governance/policies/policy-details/PolicyDetailsResults.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: vsanghishetty <[email protected]>
/hold I am reviewing and anticipate I will want to request some changes. |
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
…ormatting Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
/retest |
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
Signed-off-by: vsanghishetty <[email protected]>
/retest-required |
Quality Gate failedFailed conditions |
@vishsanghishetty: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ACM UI
PR Description
This PR introduces several updates related to localization and date/time formatting in the project, including:
This PR is for ticket
This PR is for ticket
Acceptance Criteria
Acceptance Criteria
Date/Time Formatting:
Intl.DateTimeFormat
for standard date/time formatting.Implemented dynamic relative time formatting with
Intl.RelativeTimeFormat
to handle fromNow functionality ini18n
interpolation.Credentials Page and Governance Policy Results Details:
i18n
for relative time display in the table columns that show timestamps. Replacedmoment.js
withi18n
's interpolation for relative time formatting.Unit Test Coverage:
Added unit tests to verify: