Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(usb): cdc_queue now use uint32_t length #2550

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

warmonkey
Copy link
Contributor

@warmonkey warmonkey commented Nov 4, 2024

raise cdc buffer size 32KB limit due to uint16_t length variables.

This PR fixes bug: cdc queue limited
Now CDC_TRANSMIT_QUEUE_BUFFER_PACKET_NUMBER and/or CDC_RECEIVE_QUEUE_BUFFER_PACKET_NUMBER both can be greater than 512. which every buffer size is 64B, 64*512=32768

which allows CDC_TRANSMIT_QUEUE_BUFFER_PACKET_NUMBER>512 or
CDC_RECEIVE_QUEUE_BUFFER_PACKET_NUMBER>512.

Signed-off-by: warmonkey <[email protected]>
@warmonkey warmonkey closed this Nov 5, 2024
@fpistm fpistm reopened this Nov 5, 2024
@fpistm fpistm changed the title cdc_queue.cpp change to uint32_t length chore(usb): cdc_queue now use uint32_t length Nov 5, 2024
@fpistm fpistm added the enhancement New feature or request label Nov 5, 2024
@fpistm fpistm added this to the 2.9.0 milestone Nov 5, 2024
@fpistm fpistm removed this from the 2.9.0 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

2 participants