-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added feature for processing nested structures #384
Added feature for processing nested structures #384
Conversation
Pull Request Test Coverage Report for Build 10633564917Details
💛 - Coveralls |
@msfur this is awesome, looks great as a solution for the nested structs issue and thanks for adding the tests in too! If possible, could you please add a documentation example at the end of this section too? https://pyads.readthedocs.io/en/latest/documentation/connection.html#structures-with-multiple-datatypes I will then merge. |
@chrisbeardy I have made the desired change to the documentation and added an example. |
This looks great! Any way I can support getting this merged? |
Hi @msfur This PR is ok for me (must be rebase) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nested Structure works (test also with TIMESTRUCT)
… processing nested structures
…rocessing nested structures
…rocessing nested structures
f0dbc8a
to
d3e8bbd
Compare
Hi @kryskool, |
@chrisbeardy this PR is ok for merging |
added section 3.5.0 (unreleased to changelog)
thanks all for this, will release new version soon, couple of other PRs to merge |
Great work getting this merged in all! I know I'm just a random person on the internet, but working together like this on software that most people will never hear about is truly useful for hummanity and I appreciate you. - Some random user of pyads |
I'm going to check it out and see if there's anything I can contribute. |
@msfur thanks for this great feature- I have been working with your branch of pyads for a few months now so great to see it merged into master |
Will there be a new published release of pyads that includes this soon? Itching to use it officially. |
Enables processing for nested structures, as mentioned in and fixes #308 and on Stackoverflow. Takes into account nested structures in the following form:
or
Contains adaptations to
size_of_structure()
,dict_from_bytes()
andbytes_from_dict()
and the associated tests.