Added actionOpenClosed for contactSensors (simulated) #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandazgul
reviewed
Feb 2, 2019
gandazgul
reviewed
Feb 2, 2019
gandazgul
reviewed
Feb 2, 2019
| var cmdTopic = getTopicFor(device, property, TOPIC_COMMAND); | ||
| var writeTopic = getTopicFor(device, property, TOPIC_WRITE_STATE); | ||
| subscriptions.push(cmdTopic); | ||
| if (writeTopic !== cmdTopic) { |
|
@stjohnjohnson this would be a nice one to merge. |
…orControl. Added "opensensor", "closedsensor", "switch", "notify" to doorControl Allowing "notify" to be sent on devices.
…s fallback if setStatus is absent
|
Please merge this. |
Changed door to door, notify to match EspurnaGarageDoorDeviceHandlerV2 Force sent device battery status when initialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow open/close to be conditionally invoked on simulated contact sensors. Contact sensors do not have open/close command. Simulated contact sensor with no actionable tile would be one way to update a SmartThings contact sensor through MQTT.