Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix complex if operators #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix complex if operators #23

wants to merge 1 commit into from

Conversation

dantti
Copy link
Contributor

@dantti dantti commented Apr 14, 2016

Without this fix comparing a simple QString
to a string hardcoded on template fails,
it also fixes when the string is a QByteArray
so that this renders "true" if foo is either a
QString("foo") os a QByteArray("foo")

{% if foo = 'bar' %}true{% endif %}
or
{% if 'bar' = 'bar' %}true{% endif %}

Without this fix comparing a simple QString
to a string hardcoded on template fails,
it also fixes when the string is a QByteArray
so that this renders "true" if foo is either a
QString("foo") os a QByteArray("foo")

{% if foo = 'bar' %}true{% endif %}
or
{% if 'bar' = 'bar' %}true{% endif %}
@codecov-io
Copy link

Current coverage is 69.70%

Merging #23 into master will decrease coverage by -0.35% as of 33c2f88

@@            master    #23   diff @@
=====================================
  Files          158    158       
  Stmts         9753   9838    +85
  Branches         0      0       
  Methods        235    224    -11
=====================================
+ Hit           6832   6858    +26
  Partial          0      0       
- Missed        2921   2980    +59

Review entire Coverage Diff as of 33c2f88

Powered by Codecov. Updated on successful CI builds.

@steveire
Copy link
Owner

This commit does many different things. Please split it into multiple commits each with a commit message explaining why it should be added (eg compare to python/django behavior).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants