Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix force try in the FailableIterator.next() and Connection.prepare() methods #1273

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix force try in the FailableIterator.next() and Connection.prepare() methods #1273

wants to merge 2 commits into from

Conversation

syoung-smallwisdom
Copy link

The force try is crashing and ideally, the prepare() query should throw the error rather than crashing the app. Thanks!

Thanks for taking the time to submit a pull request.

Before submitting, please do the following:

  • Run make lint to check if there are any format errors (install swiftlint first)
  • Run swift test to see if the tests pass.
  • Write new tests for new functionality.
  • Update documentation comments where applicable.

@jokerYellow
Copy link

anyone please merge this request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syoung-smallwisdom @jokerYellow