Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include CASE WHEN expression starter #294

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Include CASE WHEN expression starter #294

merged 3 commits into from
Nov 9, 2024

Conversation

k4n4ry
Copy link
Contributor

@k4n4ry k4n4ry commented Nov 6, 2024

Implements #293

stephenafamo
stephenafamo requested changes Nov 6, 2024
View reviewed changes
expr/case.go Outdated Show resolved Hide resolved
dialect/mysql/starters.go Outdated Show resolved Hide resolved
dialect/mysql/starters.go Outdated Show resolved Hide resolved
@k4n4ry k4n4ry changed the title [WIP]Include CASE WHEN expression starter Include CASE WHEN expression starter Nov 9, 2024
@k4n4ry k4n4ry marked this pull request as ready for review November 9, 2024 12:16
@k4n4ry
Copy link
Contributor Author

k4n4ry commented Nov 9, 2024

@stephenafamo
Thank you for your review. I've fixed your feedback. Could you please take another look?

@stephenafamo
Copy link
Owner

One final thing.... add the changes to CHANGELOG.md, under the Unreleased section.

Also remember to add attribution thanks (@k4n4ry )

Thanks for the PR

@stephenafamo stephenafamo merged commit 1d6c532 into stephenafamo:main Nov 9, 2024
8 checks passed
@k4n4ry k4n4ry deleted the issue-293 branch November 12, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenafamo stephenafamo stephenafamo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k4n4ry @stephenafamo