Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phytime fails to compile #166

Open
V-Z opened this issue May 13, 2022 · 2 comments
Open

phytime fails to compile #166

V-Z opened this issue May 13, 2022 · 2 comments

Comments

@V-Z
Copy link

V-Z commented May 13, 2022

Hello,
we discussed this in #157, so I just report that PhyTime in Spring 2022 release fails (Winter 2021 release worked well).

@ntakebay
Copy link

ntakebay commented May 18, 2022

I also got this error. Looking at the source, cur_lnL_loc and new_lnL_loc are only defined within #ifdef PHYREX, but I believe you forgot to add this to line 1482 of mcmc.c. I'm attaching a (zipped) patch to make it compile. phyml-3.3.20220408-phytime.patch.zip

Compilation error messages:

mcmc.c: In function 'MCMC_Root_Time':
mcmc.c:1482:24: error: 'cur_lnL_loc' undeclared (first use in this function); did you mean 'cur_lnL_seq'?
1482 | cur_lnL_loc,new_lnL_loc,tree->eval_glnL,
| ^~~~~~~~~~~
| cur_lnL_seq
mcmc.c:1482:24: note: each undeclared identifier is reported only once for each function it appears in
mcmc.c:1482:36: error: 'new_lnL_loc' undeclared (first use in this function); did you mean 'new_lnL_seq'?
1482 | cur_lnL_loc,new_lnL_loc,tree->eval_glnL,
| ^~~~~~~~~~~
| new_lnL_seq
make[2]: *** [Makefile:1216: mcmc.o] Error 1

make[2]: Leaving directory '/root/rpmbuild/BUILD/phyml-3.3.20220408/src'

@pavelToman
Copy link

pavelToman commented Apr 10, 2024

Hello there, I am hitting the same error when try to build PhyML --enable-phytime.
The patch from ntakebay works, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants