Fix diagnostic event parsing bug #199
Conversation
| @@ -51,6 +51,12 @@ func TransformDiagnosticEvent(transaction ingest.LedgerTransaction, lhe xdr.Ledg | |||
| continue | |||
| } | |||
|
|
|||
| if event.ContractId != nil { | |||
There was a problem hiding this comment.
Curious, in what scenarios would the ContractId be null? Would this be null during the original WASM upload to host?
There was a problem hiding this comment.
Yes that's one case but I also think it's unoptimized diagnostic events.
Example transaction_hash: 559f7422e90d054d77cbc32a756af55ff9838ca077f75b2e8b8329971b9eb57c
The transaction failed because invokeHostFunctionResourceLimitExceeded but it doesn't give you the contract_id that was used because the resource error is associated with the transaction and not necessarily a problem with the contract being invoked.
Could it have given a contract_id? Yes but it doesn't 🤷♀️
Can we find out the contract_id? Probably yes, with joins to transaction_id --> history_operations --> contract_id
There was a problem hiding this comment.
Ah, that makes sense. I don't think we need to always find the contract_id, we can leave that up to the user if they need to trace
Fixed diagnostic event parsing to account for events without a contract_id