Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove null char from contract data asset_code in avro files #511

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented Oct 11, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the README with the added features, breaking changes, new instructions on how to use the repository.

What

Strip out the null chars \u0000 from the asset_code column in contract_data

Why

Dune found that asset_code had null chars appended for some asset_codes which should be removed
https://stellarfoundation.slack.com/archives/C07N40J1789/p1728568351934499?thread_ts=1727985059.719139&cid=C07N40J1789

Known limitations

  • This is just a patch to get Dune unblocked for now

I believe this is caused because of the way asset_code in contracts are saved as ScVal and reconstructed to a string in stellar-etl. It seems like the null chars appear in asset_codes of type alpha12.

Next week we should:

@chowbao chowbao requested a review from a team as a code owner October 11, 2024 14:01
@chowbao chowbao merged commit a5333ff into master Oct 11, 2024
2 checks passed
@sydneynotthecity sydneynotthecity deleted the strip-null-char-contract-data-asset-code branch November 21, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants