Remove null char from contract data asset_code in avro files #511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
Thoroughness
What
Strip out the null chars
\u0000
from theasset_code
column in contract_dataWhy
Dune found that asset_code had null chars appended for some asset_codes which should be removed
https://stellarfoundation.slack.com/archives/C07N40J1789/p1728568351934499?thread_ts=1727985059.719139&cid=C07N40J1789
Known limitations
I believe this is caused because of the way
asset_code
in contracts are saved as ScVal and reconstructed to a string in stellar-etl. It seems like the null chars appear in asset_codes of type alpha12.Next week we should: