feat: switch hello_world to String #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
approved these changes
Jun 26, 2024
Symbols seem generally inferior?
auto-merge was automatically disabled
June 27, 2024 14:18
Head branch was pushed to by a user without write access
chadoh
force-pushed
the
feat/hello-strings
branch
from
e75bacd to
cca2e70
Compare
dmkozh
approved these changes
Jun 27, 2024
chadoh
added a commit
to AhaLabs/system-test
that referenced
this pull request
Jul 31, 2024
The system-test started failing in stellar/stellar-cli#1500 because it finally updated the version of `soroban-examples` to use a version that includes stellar/soroban-examples#314. The previous `invoke.ts` logic assumed that the variable would be a Symbol, but the variable has been changed to a String. I don't want to break every project that still uses `system-test` with a stale `soroban-examples` hash, so here's what I did: - dynamically define `contract` using `import()`, using a `@ts-ignore` directive because this can error if `stellar-sdk` doesn't include a `contract` export. - if `contract` is there, then we don't need to know the type of the argument. It could be a Symbol or a String or anything else. - non-`contract` logic path stays unchanged, assuming `Symbol`
leighmcculloch
pushed a commit
to stellar/system-test
that referenced
this pull request
Jul 31, 2024
The system-test started failing in stellar/stellar-cli#1500 because it finally updated the version of `soroban-examples` to use a version that includes stellar/soroban-examples#314. The previous `invoke.ts` logic assumed that the variable would be a Symbol, but the variable has been changed to a String. I don't want to break every project that still uses `system-test` with a stale `soroban-examples` hash, so here's what I did: - dynamically define `contract` using `import()`, using a `@ts-ignore` directive because this can error if `stellar-sdk` doesn't include a `contract` export. - if `contract` is there, then we don't need to know the type of the argument. It could be a Symbol or a String or anything else. - non-`contract` logic path stays unchanged, assuming `Symbol`
chadoh
added a commit
to stellar/stellar-cli
that referenced
this pull request
Aug 29, 2024
Updates `hello_world` to match the version that has been in `soroban-examples` since stellar/soroban-examples#314
willemneal
pushed a commit
to stellar/stellar-cli
that referenced
this pull request
Aug 30, 2024
Updates `hello_world` to match the version that has been in `soroban-examples` since stellar/soroban-examples#314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
hello_worldexample now usesStringinstead ofSymbolWhy
Symbols seem generally inferior?
Known limitations
Maybe we want to push newbies toward
Symbolfor some reason?