[ANCHOR-784] Remove 0 amounts from SEP-6 transaction responses #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipliu
commented
Aug 25, 2024
| expectedResponse.amountExpected = Amount(null, FIAT_USD) | ||
| expectedResponse.amountIn = Amount("1", FIAT_USD) |
There was a problem hiding this comment.
This seems wrong, we default to the request asset code when the assets are not found in the transaction.
There was a problem hiding this comment.
I think it is possible that the transaction asset had not been written by RPC and we need to respond with the asset id.
Same logic exists at:
philipliu
changed the title
lijamie98
approved these changes
Aug 30, 2024
| expectedResponse.amountExpected = Amount(null, FIAT_USD) | ||
| expectedResponse.amountIn = Amount("1", FIAT_USD) |
There was a problem hiding this comment.
I think it is possible that the transaction asset had not been written by RPC and we need to respond with the asset id.
Same logic exists at:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the 0
amount_outand 0amount_feeplaceholder values from the SEP-6 exchange transaction responses.Context
This was set as a placeholder because the request funds RPCs expected these fields always to be set.
Testing
./gradlew testDocumentation
N/A
Known limitations
N/A