Add deprecated feature #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffengy
reviewed
Feb 12, 2021
| } | ||
| } | ||
| } | ||
|
|
||
| /// The private key associated with a certificate context. | ||
| pub enum PrivateKey { | ||
| /// A CryptoAPI provider. | ||
| #[cfg(feature = "allow-deprecated")] |
There was a problem hiding this comment.
Doing it this way leads to a breaking change.
I'm fine with changing the default to CRYPT_ACQUIRE_PREFER_NCRYPT_KEY_FLAG, as that should not break anything.
We can mark it #[deprecated] but I don't think there's any advantage to hiding it behind a feature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain parts of wincrypt have been deprecated. This flag allows opt-in of the deprecated wincrypt api, instead of it being the default. NCrypt is now preferred which is a CNG api.
Fixes #63