Parallel #20
Parallel #20
Conversation
upstream pull
… params. consolidated backup functionality into a class to encapsulate the backupStartPath logic and additonal backup logic.
Pretect against accidental or melicious overwriting
|
The only thing I'd say is it would be great to have I apologize, I didn't thank you for this work earlier up, this is great! 😄 |
…termine if a value is of type Function
…will use. removed bluebird from dependencies
|
@yoiang how about this removed bluebird as a dependency and localized the use of we can add bluebird back after this and use it if we want. |
lib/firestore.js
Outdated
| .then((documentSnapshots) => documentSnapshots.docs) | ||
| .map((document) => { | ||
| return this.backupDocument(document, backupPath + '/' + document.id, logPath + collection.id + '/') | ||
| }, { concurrency: this.options.requestCountLimit }) | ||
| .catch(err=>console.error(err)) |
There was a problem hiding this comment.
I was wondering why we aren't bubbling up our errors anymore in the Promise's return result
There was a problem hiding this comment.
Ah my mistake, you removed those in the latest commit!
lib/firestore.js
Outdated
| */ | ||
| set Promise(value: Object) { | ||
| // TODO: validate this ia valid Promise-like object | ||
| this._PromiseLibrary = addMapFunction(value) |
There was a problem hiding this comment.
Why are we mapping through the promise serial resolver again vs doing them all async? Does this tie into your analysis work?
There was a problem hiding this comment.
It was a path I thought I wanted to go down until I decided to just write a func to handle promises at a given concurrency. See the latest commits.
|
It looks great, thank you again :)] |
Working towards resolution of #16 will reference #4 because there was conversation regarding this in the issue.