performance(sqlcipher): Fix burn_stack performance issue #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a cross-platform version of OP-TEE/optee_os#3102 1. Remove recursion 2. Use memset instead of while loop
alexjba
requested review from
cammellos,
richard-ramos,
caybro,
jrainville and
osmaczko
Pull Request Checklist
|
richard-ramos
approved these changes
May 10, 2023
alaibe
approved these changes
May 10, 2023
|
Someone needs to test this, ideally on mac/linux/windows x intel/m1/arm CPUs |
jrainville
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second iteration of #3464
Fixing status-im/status-desktop#10572
Implements a cross-platform version of OP-TEE/optee_os#3102
A description to understand introduced changes without reading the code.
zeromemweights about 50% of the total CPU time on M1 Macs and seems to be major performance offender.It is used to clear the stack when using variables with sensitive information.
Perf improvement on Status desktop (M1 arch):
developon lower left; This branch on upper rightScreen.Recording.2023-05-08.at.14.28.45.mov
Profiling data with app in idle:
Before
After
