Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics)_: update initializeapplication params with metrics flag and port #17116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adklempner
Copy link
Collaborator

@adklempner adklempner commented Jan 22, 2025

What does the PR do

Add parameters to InitializeApplication request for enabling prometheus and specifying port.
Corresponding status-go PR: status-im/status-go#6256

This change is necessary to enable viewing metrics locally by running Prometheus/Grafana as specified here: https://github.com/waku-org/status-metrics

Affected areas

Application startup. Default behavior introduced by this change does not change anything.

Architecture compliance

(I glanced at the document but this is a relatively minor change that doesn't involve complex logic and only touches a small part of the application)

@adklempner adklempner marked this pull request as ready for review January 22, 2025 22:39
@adklempner adklempner requested a review from a team as a code owner January 22, 2025 22:39
@adklempner adklempner requested review from noeliaSD and removed request for a team January 22, 2025 22:39
@status-im-auto
Copy link
Member

status-im-auto commented Jan 22, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 77e6b65 #1 2025-01-22 22:46:15 ~7 min macos/aarch64 🍎dmg
✔️ 77e6b65 #1 2025-01-22 22:48:28 ~9 min tests/nim 📄log
✔️ 77e6b65 #1 2025-01-22 22:50:31 ~11 min tests/ui 📄log
✔️ 77e6b65 #1 2025-01-22 22:57:14 ~18 min macos/x86_64 🍎dmg
✔️ 77e6b65 #1 2025-01-22 22:59:14 ~20 min linux-nix/x86_64 📦tgz
✔️ 77e6b65 #1 2025-01-22 23:00:24 ~21 min linux/x86_64 📦tgz
✔️ 77e6b65 #1 2025-01-22 23:05:49 ~26 min windows/x86_64 💿exe
✔️ 971a9b5 #2 2025-01-28 00:38:16 ~8 min tests/nim 📄log
✔️ 971a9b5 #2 2025-01-28 00:42:04 ~12 min tests/ui 📄log
✔️ 971a9b5 #2 2025-01-28 00:42:46 ~12 min macos/x86_64 🍎dmg
✔️ 971a9b5 #2 2025-01-28 00:46:08 ~16 min linux-nix/x86_64 📦tgz
✔️ 971a9b5 #2 2025-01-28 00:49:32 ~19 min linux/x86_64 📦tgz
✔️ 971a9b5 #2 2025-01-28 00:53:57 ~24 min windows/x86_64 💿exe
971a9b5 #2 2025-01-29 08:00:03 ~1 day 7 hr macos/aarch64 📄log

@adklempner adklempner force-pushed the feat/enable-metrics-params branch from 77e6b65 to 971a9b5 Compare January 28, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants