Remove nph from nimble deps. Install nph during nimble format task in…

…stead.
status-im · Jun 26, 2024 · 52e30a3 · 52e30a3
1 parent 00d04d5
commit 52e30a3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -169,8 +169,7 @@ jobs:
       - name: Check nph formatting
         if: runner.os == 'Linux' && matrix.branch == 'version-2-0'
         run: |
-          nimble install -y --depsOnly
-          nph .
+          nimble format
           git diff --exit-code
 
       - name: Run tests

diff --git a/rocksdb.nimble b/rocksdb.nimble
@@ -8,9 +8,13 @@ skipDirs = @["examples", "tests"]
 mode = ScriptMode.Verbose
 
 ### Dependencies
-requires "nim >= 1.6", "results", "tempfile", "unittest2", "nph#head"
+requires "nim >= 1.6", "results", "tempfile", "unittest2"
 
+# Format only works with nim version 2
 task format, "Format nim code using nph":
+  # Using the latest nph commit for now because the latest tagged version
+  # doesn't work with the latest nim 2 version
+  exec "nimble install nph@#head"
   exec "nph ."
 
 task clean, "Remove temporary files":