Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch classification id directly from the json response. #724

Merged
merged 1 commit into from
May 13, 2024

Conversation

bjornandre
Copy link
Contributor

@bjornandre bjornandre commented May 13, 2024

The id element was introduced in Klass API with this PR

Previously the id element was parsed from the URL by some fragile code that has now been removed.

@bjornandre bjornandre requested review from a team and runejo May 13, 2024 11:18
Copy link

sonarcloud bot commented May 13, 2024

@bjornandre bjornandre merged commit 3ee24e7 into master May 13, 2024
11 checks passed
@bjornandre bjornandre deleted the fix-id-parsing branch May 13, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants