Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interceptors should decide whether a value should be mapped to null, not the MapTraverser. #41

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Interceptors should decide whether a value should be mapped to null, not the MapTraverser. #41

merged 1 commit into from
Apr 5, 2024

Conversation

bjornandre
Copy link
Contributor

No description provided.

@bjornandre bjornandre requested a review from a team April 4, 2024 19:47
kschulst
kschulst approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@kschulst kschulst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! If interceptors return a null value, then we would effectively skip the transformation. I guess this was the original intention of the code, but clearly it has not been challenged with regards to potential leakage of sensitive data.

@bjornandre bjornandre merged commit 712ae05 into master Apr 5, 2024
2 checks passed
@bjornandre bjornandre deleted the handle-null-mappings branch April 5, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschulst kschulst kschulst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjornandre @kschulst